Skip to content

[CustomOP][Refactor] Register CustomOP instead of overwrite forward_oot #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CustomOP][Refactor] Register CustomOP instead of overwrite forward_oot #1647

wants to merge 1 commit into from

Conversation

MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Jul 7, 2025 •
edited by github-actions bot
Loading

What this PR does / why we need it?

Register CustomOP instead of overwrite forward_oot.

Next step:

  • add ut for the custom ops

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

@Yikun Yikun mentioned this pull request Jul 8, 2025
Open
24 tasks
@MengqingCao MengqingCao force-pushed the customop branch 3 times, most recently from d5899fd to ddf940f Compare July 8, 2025 08:48
@MengqingCao MengqingCao force-pushed the customop branch 2 times, most recently from 75dc907 to f688f36 Compare July 10, 2025 06:55
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.52941% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.96%. Comparing base (c30ddb8) to head (46fb690).
Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/ops/rotary_embedding.py 93.75% 4 Missing ⚠️
vllm_ascend/ops/fused_moe.py 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (98.52%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1647       +/-   ##
===========================================
+ Coverage   27.39%   55.96%   +28.56%     
===========================================
  Files          56       85       +29     
  Lines        6191    10203     +4012     
===========================================
+ Hits         1696     5710     +4014     
+ Misses       4495     4493        -2
Flag Coverage Δ
unittests 55.96% <98.52%> (+28.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MengqingCao MengqingCao marked this pull request as ready for review July 14, 2025 09:36
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MengqingCao
[CustomOP][Refactor] Register CustomOP instead of overwrite forward_oot
46fb690 
  * fix rope ut
  * add layernorm ut
  * add ut for common fused moe
  * update test

Signed-off-by: MengqingCao <cmq0113@163.com>
@wangxiyuan wangxiyuan mentioned this pull request Jul 16, 2025
Open
This was referenced Jul 16, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:core module:ops module:quantization module:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MengqingCao